[PATCH] D76240: [Sanitizers][Test] If the default linker is LLD, disable threads

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 14:06:07 PDT 2020


nemanjai added a comment.

In D76240#1942048 <https://reviews.llvm.org/D76240#1942048>, @efriedma wrote:

> Adding a flag like that requires a comment explaining the need each place you're adding it.
>
> Is there some way to refactor this so the code isn't scattered across five Python files?


I certainly don't mind adding the comments, that's a good point. I personally wasn't able to find a way to make the change in just one place - and I spent a bunch of time trying before I posted this. :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76240/new/

https://reviews.llvm.org/D76240





More information about the llvm-commits mailing list