[PATCH] D76752: [WebAssembly] Move event section before global section

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 11:21:20 PDT 2020


aheejin marked 2 inline comments as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:1654
+         WASM_SEC_ORDER_TARGET_FEATURES}, // WASM_SEC_ORDER_PRODUCERS,
+        {WASM_SEC_ORDER_TARGET_FEATURES}  // WASM_SEC_ORDER_TARGET_FEATURES
 };
----------------
tlively wrote:
> aheejin wrote:
> > Hmm, clang-format makes this look ugly, and I think I remember you decided not to format this code intentionally before, but having consistent style throughtout wasm code is also better. WDYT? @tlively 
> Yeah, I think I did intentionally exclude this code from styling before, but I'd be ok letting clang-format style it now. I think it would look better if we move the inline comments to their own lines.
Good idea! Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76752/new/

https://reviews.llvm.org/D76752





More information about the llvm-commits mailing list