[PATCH] D76787: [mlir][Diagnostics] Don't print note source line if it is the same as the previous diagnostic

[River Riddle via Phabricator via llvm-commits]

rriddle marked an inline comment as done.
rriddle added a comment.

In D76787#1941737 <https://reviews.llvm.org/D76787#1941737>, @mehdi_amini wrote:

> We don't have tests for the note emission?


We don't have tests that check that a specific line of source code is printed. We have many tests for note emission.



================
Comment at: mlir/include/mlir/IR/Diagnostics.h:551
+  void emitDiagnostic(Location loc, Twine message, DiagnosticSeverity kind,
+                      bool displaySourceLine = true);
 
----------------
mehdi_amini wrote:
> Worth documenting it here?
When I originally wrote a comment it came out as redundant with the parameter name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76787/new/

https://reviews.llvm.org/D76787