[PATCH] D75631: [llvm-objdump] Fix reliability of call target disassembling

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked 2 inline comments as done.
thopre added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1494
                   [=](const std::pair<uint64_t, SectionRef> &O) {
                     return O.first <= Target;
                   });
----------------
davidb wrote:
> Can we check the section isText() in here rather than having CodeSectionAddresses?
We can't because partition_point expects a range where the predicate is true at the beginning and false later. If we check isText it'll alternate between true and false. Since it's a predicate, there's unfortunately no way to return a "skip" value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75631/new/

https://reviews.llvm.org/D75631