[PATCH] D75631: [llvm-objdump] Fix reliability of call target disassembling

[Dave Bozier via Phabricator via llvm-commits]

davidb added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1500
+                if (It != CodeSectionAddresses.begin()) {
+                  uint64_t SelectedSectionAddr = It->first;
+                  --It;
----------------
This will cause an unused variable warning in release? (it is only used in assert).

I'm not sure this assert is really valuable. In. fact, this might trigger for binaries linked with OVERLAY segments (See D44780).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75631/new/

https://reviews.llvm.org/D75631