[PATCH] D76769: [AssumeBundles] Preserve information in EarlyCSE

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/IR/KnowledgeRetention.h:38
+void SalvageKnowledge(Instruction* I);
+
 /// It is possible to have multiple Value for the argument of an attribute in
----------------
Now that I see this I wonder why we have captial letters in the beginning.


================
Comment at: llvm/test/Transforms/EarlyCSE/guards.ll:4
+; RUN: opt < %s -S -basicaa -early-cse-memssa | FileCheck %s --check-prefixes=CHECK,NO_ASSUME
+; RUN: opt < %s -S -basicaa -early-cse-memssa --enable-knowledge-retention | FileCheck %s --check-prefixes=CHECK,USE_ASSUME
 
----------------
Can you please add the check lines and run the update script first in a local NFC commit. diff against that one and commit it just prior to this patch once accepted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76769/new/

https://reviews.llvm.org/D76769