[PATCH] D76739: [llvm-objdump] Replace array_pod_sort with llvm::stable_sort

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre accepted this revision.
thopre added a comment.
This revision is now accepted and ready to land.

LGTM. This is what I think is causing tools/llvm-objdump/X86/disassemble-functions.test to fail in some settings (see my comment https://reviews.llvm.org/D75631#1940245)



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1205-1207
+  // Create a mapping from virtual address to section. An empty section can
+  // cause more than one section at the same address. Use a stable sort to
+  // stabalize the output.
----------------
Also non allocatable sections have 0 for start address. Dunno if it's worth mentioning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76739/new/

https://reviews.llvm.org/D76739