[PATCH] D76073: [compiler-rt][tsan] Fix: Leak of ThreadSignalContext memory mapping when destroying fibers.

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 03:45:31 PDT 2020


dvyukov added a comment.

> Maybe it would be beneficial to do the same for the thread state?

Generally yes. A good abstraction is good. But the devil may be in details :)
Also note that Processor is pure abstract, while ThreadState has several platform-dependent clean up parts.
Also the shutdown sequence is the hardest part, the order of things was crafted very carefully.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76073/new/

https://reviews.llvm.org/D76073





More information about the llvm-commits mailing list