[PATCH] D76754: [MC][AArch64] Make .reloc support arbitrary relocation types
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 25 02:40:48 PDT 2020
grimar added inline comments.
================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp:403
if (!Value)
return; // Doesn't change encoding.
MCFixupKindInfo Info = getFixupKindInfo(Fixup.getKind());
----------------
It looks like `if (!Value)` could be tested first? `Value` is argument and it looks a bit strange that it is tested so late to do `return`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76754/new/
https://reviews.llvm.org/D76754
More information about the llvm-commits
mailing list