[PATCH] D76567: AMDGPU: Implement getMemcpyLoopLoweringType
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 25 01:35:35 PDT 2020
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:332
+ // introduce them.
+ if (MinAlign == 2)
+ return Type::getInt8Ty(Context);
----------------
`<=`? You can't do unaligned dword (or multi-dword) accesses, can you?
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:349-351
+ uint64_t Size = ConstLen->getZExtValue();
+ if (Size >= 16)
+ return VectorType::get(Type::getInt32Ty(Context), 4);
----------------
Don't all these (multi-)dword cases need to be guarded by `MinAlign >= 4`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76567/new/
https://reviews.llvm.org/D76567
More information about the llvm-commits
mailing list