[PATCH] D76285: [X86][MC] Fix the bug for prefix padding support

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 22:24:42 PDT 2020


skan marked an inline comment as done.
skan added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:973-977
-      if (OrigSize == 0 || Relaxable.empty()) {
-        Relaxable.clear();
-        continue;
-      }
 
----------------
The existing code in `finishLayout` intends to not pad instructions following boundary align by checking whether `F` is `MCBoundaryAlignFragment`.  But this early `continue` prevents the control flow from reaching that check.  This patch is pretty small (delete 3 lines) and is a bug fix, could reviewers take a close look at it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76285/new/

https://reviews.llvm.org/D76285





More information about the llvm-commits mailing list