[PATCH] D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue.

[Dan Liew via Phabricator via llvm-commits]

delcypher created this revision.
delcypher added reviewers: kubamracek, yln, vitalybuka, kcc, filcab.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

When ASan reports an issue the contents of the system log buffer
(`error_message_buffer`) get flushed to the system log (via
`LogFullErrorReport()`). After this happens the buffer is not cleared
but this is usually fine because the process usually exits soon after
reporting the issue.

However, when ASan runs in `halt_on_error=0` mode execution continues
without clearing the buffer. This leads to problems if more ASan
issues are found and reported.

1. Duplicate ASan reports in the system log. The Nth (start counting from 1)

ASan report  will be duplicated (M - N) times in the system log if M is the
number of ASan issues reported.

2. Lost ASan reports. Given a sufficient

number of reports the buffer will fill up and consequently cannot be appended
to. This means reports can be lost.

The fix here is to reset `error_message_buffer_pos` to 0 which
effectively clears the system log buffer.

A test case is included but unfortunately it is Darwin specific because
querying the system log is an OS specific activity.

rdar://problem/55986279


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76749

Files:
  compiler-rt/lib/asan/asan_report.cpp
  compiler-rt/test/asan/TestCases/Darwin/duplicate_os_log_reports.cpp
  compiler-rt/test/lit.common.cfg.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76749.252482.patch
Type: text/x-patch
Size: 4585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200325/e0c9b33f/attachment.bin>