[PATCH] D76656: [mlir][Pass] Add a tablegen backend for defining Pass information

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 15:06:48 PDT 2020


jpienaar accepted this revision.
jpienaar marked an inline comment as done.
jpienaar added a comment.
This revision is now accepted and ready to land.

LG, thanks



================
Comment at: mlir/lib/TableGen/Pass.cpp:1
+//===- Pass.cpp - Pass related classes ------------------------------------===//
+//
----------------
Should this b TableGen (or ODS) pass related classes? Given it is not about Pass "IR side"


================
Comment at: mlir/tools/mlir-tblgen/PassGen.cpp:31
+static void emitRegistration(ArrayRef<Pass> passes, raw_ostream &os) {
+  os << "#ifdef GEN_PASS_REGISTRATION\n";
+  for (const Pass &pass : passes) {
----------------
I could have sworn I added a small helper class to automate this :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76656/new/

https://reviews.llvm.org/D76656





More information about the llvm-commits mailing list