[PATCH] D76673: [Attributor][FIX] Prevent alignment breakage wrt. must-tail calls

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 13:28:38 PDT 2020


jdoerfert added a comment.

In D76673#1938580 <https://reviews.llvm.org/D76673#1938580>, @lebedev.ri wrote:

> How do we know this is only about alignment?


Good point. It is about:
`Attribute::StructRet, Attribute::ByVal, Attribute::InAlloca, Attribute::InReg, Attribute::Returned, Attribute::SwiftSelf, Attribute::SwiftError, Attribute::Alignment`

We derive Returned and Alignment so I need to add the prevention to returned as well. I'll also move it to the manifest as we can use the derived value internally just fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76673/new/

https://reviews.llvm.org/D76673





More information about the llvm-commits mailing list