[PATCH] D76715: [mlir] Clarify constraint on derived attribute

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/docs/OpDefinitions.md:183
 
+   All derived attributes should be materializable as an Attribute. That is,
+   even though they are not materialized, it should be possible to store as
----------------
Why is this indented?


================
Comment at: mlir/include/mlir/IR/OpBase.td:1390
+// Note: All derived attributes should be materializable as an Attribute. E.g.,
+// do not used DerivedAttr for things that could not have been stored as
+// Attribute.
----------------
typo: used


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76715/new/

https://reviews.llvm.org/D76715