[PATCH] D76574: [MCInstPrinter] Pass `Address` parameter to MCOI::OPERAND_PCREL typed operands. NFC

Tue Mar 24 09:07:15 PDT 2020

MaskRay added inline comments.

================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1350

-void AArch64InstPrinter::printAlignedLabel(const MCInst *MI, unsigned OpNum,
+void AArch64InstPrinter::printAlignedLabel(const MCInst *MI, uint64_t Address,
+                                           unsigned OpNum,
----------------
jhenderson wrote:
> `Address` is unused. Is this going to cause an unused variable warning?
LLVM CMake/gn enables -Wno-unused-parameter. This is somewhat common in LLVM.

`/*Address*/` is not used to reduce diff when a future change adds the support.

================
Comment at: llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinter.cpp:159
+void SystemZInstPrinter::printPCRelTLSOperand(const MCInst *MI,
+                                              uint64_t Address, int OpNum,
                                               raw_ostream &O) {
----------------
jhenderson wrote:
> Ditto.
Here `/*Address*/` is used so that when the support is added, the code doesn't need to touch this line.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76574/new/

https://reviews.llvm.org/D76574