[PATCH] D72325: [AMDGPU] Fix cluster size threshold calculation
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 24 09:07:13 PDT 2020
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:481
- // FIXME: NumLoads should not be subtracted 1. This is to match behavior
- // of clusterNeighboringMemOps which was previosly passing cluster length
- // less 1. LoadClusterThreshold should be tuned instead.
- return ((NumLoads - 1) * (RI.getRegSizeInBits(*DstRC) / 8)) <=
- LoadClusterThreshold;
+ return (NumLoads * (RI.getRegSizeInBits(*DstRC) / 8)) <= LoadClusterThreshold;
}
----------------
Extra parens around LHS
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72325/new/
https://reviews.llvm.org/D72325
More information about the llvm-commits
mailing list