[PATCH] D76702: [ValueTracking] improve undef/poison analysis for constants

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 08:02:45 PDT 2020


aqjune added a comment.

As `D76010`'s review is taking time, I'm fine with shipping this first.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4623
+  if (auto *C = dyn_cast<Constant>(V))
+    return !C->containsUndefElement();
+
----------------
We should check whether the constant or an element of it is not constexpr too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76702/new/

https://reviews.llvm.org/D76702





More information about the llvm-commits mailing list