[PATCH] D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0

[Xing GUO via Phabricator via llvm-commits]

Higuoxing updated this revision to Diff 252287.
Higuoxing added a comment.

Addressed comments.

- Rename test case to `dynamic.test`.
- Add genral comment for whole test.
- Indent continuous lines in test.
- Group local symbols, and remove nonsense Binding for local symbol.
- Move check tags right below `RUN` instruction.
- Rename `EMPTY` check tag to `NO-SYMS`

------------------------------

- Make `llvm-nm` imitate `gnu-nm`'s behavior.

To make `llvm-nm` behave like `gnu-nm`, I have to remove `sh_size % sizeof(Elf_Sym)` check in `dynamic_symbol_begin()`, I'm wondering if @grimar is happy with this, since you are concerned about this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76081/new/

https://reviews.llvm.org/D76081

Files:
  llvm/include/llvm/Object/ELFObjectFile.h
  llvm/test/tools/llvm-nm/dynamic.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76081.252287.patch
Type: text/x-patch
Size: 3827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200324/bd5a200f/attachment-0001.bin>