[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 03:44:08 PDT 2020


SjoerdMeijer added a comment.

Patches with functional changes but without tests are a bit "suspicious".  In this case, I see it might be tricky. You could argue that it should be incorporated in the patch that includes the tests, so we can see what's happening. But perhaps separating this out is cleaner, if the other patch is big. But can you at least make the next patch dependent on this one, so we know where this is used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76617/new/

https://reviews.llvm.org/D76617





More information about the llvm-commits mailing list