[PATCH] D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/unimplemented-features.test:1
+## Test dumping dynamic symbols from non-ELF files will emit warning.
+
----------------
I'd change this to "Test dumping dynamic symbols reports a warning if the operation is unsupported for the file format."


================
Comment at: llvm/test/tools/llvm-objdump/unimplemented-features.test:3
+
+# MachO object file.
+# RUN: yaml2obj %s --docnum=1 -o %t1.o
----------------
'##' here and below for all comments.


================
Comment at: llvm/test/tools/llvm-objdump/unimplemented-features.test:14
+# XCOFF object file.
+# RUN: cp %p/Inputs/xcoff-section-headers.o %t3.o
+# RUN: llvm-objdump --dynamic-syms %t3.o 2>&1 | \
----------------
No need for the `cp`. It's okay to reference the binary directly in the llvm-objdump call here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75756/new/

https://reviews.llvm.org/D75756