[PATCH] D76674: [Attributor] Derive better alignment for accessed pointers

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 01:35:41 PDT 2020


lebedev.ri added a comment.

In D76674#1938558 <https://reviews.llvm.org/D76674#1938558>, @jdoerfert wrote:

> In D76674#1938540 <https://reviews.llvm.org/D76674#1938540>, @lebedev.ri wrote:
>
> > That's the patch i showed, yes :)
> >  I'm not sure this is sound.
> >  Given underaligned load, we can't just take max(align of load, abi alignment)
>
>
> Hm, so we can only look at the abi if the load alignment is unspecified?


I strongly believe so, otherwise there would be no point in specifying an alignment
smaller than the abi alignment on load/store, and no way to do underaligned loads/stores,
which is obviously not the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76674/new/

https://reviews.llvm.org/D76674





More information about the llvm-commits mailing list