[PATCH] D76652: [AArch64][GlobalISel] Don't localize TLS G_GLOBAL_VALUEs on Darwin.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 23:57:55 PDT 2020


aemerson marked an inline comment as done.
aemerson added a subscriber: t.p.northover.
aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13937
+    const GlobalValue &GV = *MI.getOperand(1).getGlobal();
+    if (GV.isThreadLocal() && Subtarget->isTargetMachO())
+      return false;
----------------
paquette wrote:
> Why not `Subtarget->isTargetDarwin()`?
This is the same condition as the one used for determining whether or not we can select TLS globals in the selector. I assumed from @t.p.northover 's implementation that it was a MachO thing rather than specifically Darwin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76652/new/

https://reviews.llvm.org/D76652





More information about the llvm-commits mailing list