[PATCH] D75664: [Coroutines] Also check lifetime intrinsic for local variable when build coroutine frame

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 21:45:38 PDT 2020


junparser marked an inline comment as done.
junparser added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1470
+            break;
+        }
+      else
----------------
junparser wrote:
> modocache wrote:
> > Nit-pick: I think the LLVM coding style would have you remove these `for` loop braces. There's only a single statement in the `for` loop, the `if` statement above, so you technically don't need these here.
> Thanks, I'll update this one.
we should keep the braces, since there is another else  below


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75664/new/

https://reviews.llvm.org/D75664





More information about the llvm-commits mailing list