[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 23 16:21:31 PDT 2020
dblaikie added inline comments.
================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:134
+ if (Err)
+ return make_error<DWPError>("Cannot parse compile unit header");
+ Header.HeaderSize = Offset;
----------------
That's probably a fairly opaque error message compared to returning Err here (possibly extracting the string from Err and adding a prefix, one example of that is here: https://github.com/llvm-mirror/clang/blob/master/lib/Tooling/Execution.cpp#L76 - or the Error could be passed up unmodified, potentially, though that might give a less legible message to the user). Same goes for other error failures in this function.
Also, and I know it's annoying to make them, but each of these failure paths should have tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75485/new/
https://reviews.llvm.org/D75485
More information about the llvm-commits
mailing list