[PATCH] D76644: [mlir] [VectorOps] A "reference" lowering of vector.transpose to LLVM IR

Aart Bik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 15:48:53 PDT 2020


aartbik created this revision.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.
aartbik added reviewers: nicolasvasilache, andydavis1, rriddle.
aartbik updated this revision to Diff 252161.
aartbik added a comment.
aartbik marked 2 inline comments as done.

tagged ''' with mlir where applicable



================
Comment at: mlir/include/mlir/Dialect/Vector/VectorOps.td:91
     Examples:
-
+    ```
       // Simple dot product (K = 0).
----------------
You need `mlir` after the ticks


================
Comment at: mlir/include/mlir/Dialect/Vector/VectorOps.td:91
     Examples:
-
+    ```
       // Simple dot product (K = 0).
----------------
rriddle wrote:
> You need `mlir` after the ticks
like so?


Makes the vector.tranpose runnable on CPU.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76644

Files:
  mlir/include/mlir/Dialect/Vector/VectorOps.h
  mlir/include/mlir/Dialect/Vector/VectorOps.td
  mlir/lib/Dialect/Vector/VectorTransforms.cpp
  mlir/test/Dialect/Vector/vector-contract-transforms.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76644.252161.patch
Type: text/x-patch
Size: 15210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200323/d71ead2d/attachment.bin>


More information about the llvm-commits mailing list