[PATCH] D76603: [MLIR] Insert loop.yield to IfOp regions only if it's void.

[Nagy Mostafa via Phabricator via llvm-commits]

nmostafa accepted this revision.
nmostafa added a comment.

LGTM. Thanks for fixing this !



================
Comment at: mlir/include/mlir/Dialect/LoopOps/LoopOps.td:234
+      return OpBuilder(&body,
+                       results().empty() ?  std::prev(body.end()) : body.end());
     }
----------------
nit: extra space after "?" @ line 240 as well. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76603/new/

https://reviews.llvm.org/D76603