[PATCH] D76336: [DWARF] Emit DW_AT_call_pc for tail calls

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 14:11:23 PDT 2020


vsk added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:873
       const MCSymbol *PCAddr =
           (IsTail && !tuneForGDB())
               ? nullptr
----------------
djtodoro wrote:
> I still think we can avoid the PCAddr here as `(IsTail && !useGNUAnalogForDwarf5Feature(DD))`, if we want to use the call_pc for  gdb + dwarf5 tunning? 
> And also update the comment above.
Ah right, sorry I missed this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76336/new/

https://reviews.llvm.org/D76336





More information about the llvm-commits mailing list