[PATCH] D74324: Tools emit the bug report URL on crash
Owen Reynolds via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 23 12:01:02 PDT 2020
gbreynoo marked an inline comment as done.
gbreynoo added inline comments.
================
Comment at: llvm/lib/Support/PrettyStackTrace.cpp:147
+
+void llvm::SetCustomBugReportMsg (const char* msg) {
+ customBugReportMsg = msg;
----------------
jhenderson wrote:
> No need for the explicit `llvm::` - you are inside a `using namespace llvm` file.
>
> Also `msg` -> `Msg`.
I've found it is required, it's also consistent the other global functions in this file.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74324/new/
https://reviews.llvm.org/D74324
More information about the llvm-commits
mailing list