[PATCH] D76598: [GlobalISel] support narrow G_IMPLICIT_DEF for DstSize % NarrowSize != 0

Dominik Montada via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 10:55:50 PDT 2020


gargaroff added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:742-743
+      Register AnyExtReg = DstReg;
+      if (DstTy.isVector())
+        AnyExtReg = MRI.createGenericVirtualRegister(LLT::scalar(SizeOp0));
+
----------------
arsenm wrote:
> I don't think casting the vector type to a scalar makes sense, and this should introduce a vector anyext
Yeah that is a good point. Fixed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76598/new/

https://reviews.llvm.org/D76598





More information about the llvm-commits mailing list