[PATCH] D73051: [GlobalISel][AMDGPU] Legalize saturating add/subtract

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Can you also add some end to end IR tests make sure to stress SALU vs. VALU for a mix of scalar and vector types



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2623-2624
+    LLT Ty = MRI.getType(Dst);
+    if (!Ty.isVector())
+      return Helper.lowerAddSubSatToAddoSubo(MI) == LegalizerHelper::Legalized;
+    // Lowering to min/max produces more instructions but they are all
----------------
By scalar vs. vector, I meant SGPR vs. VGPR. I haven't looked at whether this registers a real improvement here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73051/new/

https://reviews.llvm.org/D73051