[PATCH] D76598: [GlobalISel] support narrow G_IMPLICIT_DEF for DstSize % NarrowSize != 0
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 23 08:41:54 PDT 2020
arsenm added a comment.
I added some test cases in db3f3f0240bb3a6c6e75a547ab7c6efeca4a81ee <https://reviews.llvm.org/rGdb3f3f0240bb3a6c6e75a547ab7c6efeca4a81ee> that this should impact, can you rebase on top of that?
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:742-743
+ Register AnyExtReg = DstReg;
+ if (DstTy.isVector())
+ AnyExtReg = MRI.createGenericVirtualRegister(LLT::scalar(SizeOp0));
+
----------------
I don't think casting the vector type to a scalar makes sense, and this should introduce a vector anyext
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76598/new/
https://reviews.llvm.org/D76598
More information about the llvm-commits
mailing list