[PATCH] D76602: [MLIR] Introduce std.alloca op

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

In D76602#1936610 <https://reviews.llvm.org/D76602#1936610>, @nicolasvasilache wrote:

> The amount of copy-pasta is uncanny, is there a way to factor out the 90%+ common part?
>  Also, please use the assemblyFormat for parsing and printing,


I was thinking the same. The duplication is unfortunate and it's all in StandardToLLVM - it's possible to factor it all out if we get rid of useAlloca because the AllocOp lowering is conditional on that. Should I remove useAlloca in this patch itself and mostly merge AllocOpLowering and AllocaOpLowering? Merging the parse/print methods is straightforward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76602/new/

https://reviews.llvm.org/D76602