[PATCH] D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing marked 2 inline comments as done.
Higuoxing added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-objdump.rst:88-91
+.. option:: -T, --dynamic-syms
+
+  Display the contents of the dynamic symbol table.
+
----------------
jhenderson wrote:
> Lexicographically, 'T' is before 't', so this should probably be before the -t option.
It seems that `-r, --reloc` is before `-R, --dynamic-reloc`, `-d, --disassemble` is before `-D, --disassemble-all`. I'm a little confused .. 🤣


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1885-1887
+void printSymbol(const ObjectFile *O, const SymbolRef &Symbol,
+                 StringRef FileName, StringRef ArchiveName,
+                 StringRef ArchitectureName, bool DumpDynamic) {
----------------
jhenderson wrote:
> As this function is now unindented, you need to run clang-format on the whole function. Sorry, if I incorrectly commented incorrectly on something being an unrelated formatting before! Phabricator doesn't show the indentation change as an actual change.
Never mind, I could format this now : )
I was afraid of unwanted format bringing troubles for reviewing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75756/new/

https://reviews.llvm.org/D75756