[PATCH] D76139: [Target][ARM] Change VPTMaskValues to the correct encoding

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 02:43:14 PDT 2020


simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.

LGTM, with only one tiny remaining nitpick.



================
Comment at: llvm/lib/Target/ARM/Utils/ARMBaseInfo.h:97
+namespace ARM {
+  /// Mask values for VPT Blocks, to be used by MCOperands.
+  /// Note that this is different from the "real" encoding used by the
----------------
Perhaps adjust this comment to say "IT and VPT blocks", since the same values are appropriate to either.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76139/new/

https://reviews.llvm.org/D76139





More information about the llvm-commits mailing list