[PATCH] D76550: [Attributor] Improve the alignment of the loads
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 23 01:38:31 PDT 2020
courbet added a comment.
In D76550#1935732 <https://reviews.llvm.org/D76550#1935732>, @lebedev.ri wrote:
> @courbet To be honest
>
> explicit MaybeAlign(uint64_t Value) {
> assert((Value == 0 || llvm::isPowerOf2_64(Value)) &&
> "Alignment is neither 0 nor a power of 2");
> if (Value)
> emplace(Value);
> }
>
>
> that if-check looks like a major rake.
I'm not sure what you mean here exactly. What do you think would be an appropriate check ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76550/new/
https://reviews.llvm.org/D76550
More information about the llvm-commits
mailing list