[PATCH] D76562: [llvm-objcopy] Recognize llvm-strip-$major as a tool name

Mon Mar 23 01:38:30 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/tool-name.test:13
+# RUN: %t/strip.exe --help | FileCheck --check-prefix=STRIP %s
+# RUN: %t/x86_64-linux-gnu-strip --help | FileCheck --check-prefix=STRIP %s
+
----------------
Maybe worth a test case for "[llvm-]strip" etc being in the middle of the name, i.e. something like "gnu-llvm-strip-11". Perhaps it could replace this last test case, as I don't think that one then provides additional coverage.

================
Comment at: llvm/test/tools/llvm-objcopy/tool-name.test:32
+
+# RUN: llvm-install-name-tool --help | FileCheck --check-prefix=INSTALL %s
+# RUN: %t/llvm-install-name-tool-11 --help | FileCheck --check-prefix=INSTALL %s
----------------
I would expect this to have the same set of cases as the other tools. I don't see why they are unique, just because it's emulating the install_name_tool.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76562/new/

https://reviews.llvm.org/D76562