[PATCH] D76439: [SDAG] fix crash in getNegatedExpression() from altered number of uses

qshanz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 22 19:20:02 PDT 2020


steven.zhang added a comment.

We need to update the cost. For now, it returns the first operand immediately if it is not expensive. But it could be neutral. And we will have problems if the cost of second operand is cheap. Because we should return cheap, but now, it is neutral.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76439/new/

https://reviews.llvm.org/D76439





More information about the llvm-commits mailing list