[PATCH] D76573: [mlir] Revamp operation documentation generation

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 22 18:47:46 PDT 2020


bondhugula added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpDocGen.cpp:231
+                           ArrayRef<Type> types, raw_ostream &os) {
+  os << "# '" << dialect.getName() << "' Dialect definition\n\n";
+  emitIfNotEmpty(dialect.getSummary(), os);
----------------
Should this be just changed to `dialect.getName() << " Dialect\n"? It's a bit odd to see Dialect -> Dialect 'xyz' definition here:
https://mlir.llvm.org/docs/Dialects/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76573/new/

https://reviews.llvm.org/D76573





More information about the llvm-commits mailing list