[PATCH] D74621: ValueTracking: Fix crash on weird size bswap

[Matt Arsenault via Phabricator via llvm-commits]

arsenm abandoned this revision.
arsenm added a comment.

In D74621#1878391 <https://reviews.llvm.org/D74621#1878391>, @nikic wrote:

> So the APInt support is there now, but we still have to do something here. I would suggest to enforce this requirement in the IR verifier (it already has a bunch of similar checks in visitIntrinsicCall), so that individual code handling bswaps doesn't have to deal with it.


I would suggest to eliminate the restriction from the langref. The GlobalISel legalizer at least handles the case just fine

In D74621#1878391 <https://reviews.llvm.org/D74621#1878391>, @nikic wrote:

> So the APInt support is there now, but we still have to do something here. I would suggest to enforce this requirement in the IR verifier (it already has a bunch of similar checks in visitIntrinsicCall), so that individual code handling bswaps doesn't have to deal with it.


Verifier check added in b76bbcc60db6cd7d42bf46f2fcdc6784250554d7 <https://reviews.llvm.org/rGb76bbcc60db6cd7d42bf46f2fcdc6784250554d7>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74621/new/

https://reviews.llvm.org/D74621