[PATCH] D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 22 07:27:08 PDT 2020


Higuoxing updated this revision to Diff 251886.
Higuoxing added a comment.
Herald added a subscriber: rupprecht.

- Add some test cases.

Sorry, I forget that `llvm-objdump` cannot dump dynamic symbols until D75756 <https://reviews.llvm.org/D75756> lands which depends on this revision. Hence I crafeted these tests based on `llvm-nm`. Can we use these tests as `--dynamic` dedicated tests as well (@jhenderson metioned here <https://reviews.llvm.org/D76213#1930891>)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76081/new/

https://reviews.llvm.org/D76081

Files:
  llvm/include/llvm/Object/ELFObjectFile.h
  llvm/test/tools/llvm-nm/dynamic-symbols.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76081.251886.patch
Type: text/x-patch
Size: 3654 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200322/a427beb5/attachment.bin>


More information about the llvm-commits mailing list