[PATCH] D73664: [PowerPC][Future] Add Support For Functions That Do Not Use A TOC.

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 21 15:29:33 PDT 2020


amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCScheduleP9.td:44
   // Do not support QPX (Quad Processing eXtension), SPE (Signal Procesing
   // Engine) or prefixed instructions on Power 9.
+  let UnsupportedFeatures = [HasQPX, HasSPE, PrefixInstrs, PCRelativeMemops];
----------------
nit: We should add PC relative mem ops to the list in the comment.


================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-call-linkage-leaf.ll:1
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN:   -mcpu=future < %s | FileCheck %s --check-prefix=CHECK-S
----------------
It would be good to add `-ppc-asm-full-reg-names` to this, and the rest of the test cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73664/new/

https://reviews.llvm.org/D73664





More information about the llvm-commits mailing list