[PATCH] D76248: Fix a bug in the inliner that causes subsequent double inlining

Sat Mar 21 14:57:10 PDT 2020

hoyFB added a comment.

In D76248#1935263 <https://reviews.llvm.org/D76248#1935263>, @nikic wrote:

> FTR the simplification in question (D75815 <https://reviews.llvm.org/D75815>) has since been reverted and added to InstCombine instead. See also there for a smaller reproducer. Is this change still needed now?

That's a good point. Thanks for the information. Since D75815 <https://reviews.llvm.org/D75815> has been reverted, the problem in discussion here won't be reproducible. But it's still not guaranteed that a physical callsite can not be reused by two call edges in the future. Maybe turning this fix into an assert? Please let me know your thoughts. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76248/new/

https://reviews.llvm.org/D76248