[PATCH] D76550: [Attributor] Improve the alignment of the loads

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5543
   /// call position \p ACS. The values are appended to \p ReplacementValues.
-  void createReplacementValues(Type *PrivType, AbstractCallSite ACS,
-                               Value *Base,
+  void createReplacementValues(unsigned Alignment, Type *PrivType,
+                               AbstractCallSite ACS, Value *Base,
----------------
This should just take `MaybeAlign`.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5637-5640
+          unsigned Alignment =
+              AlignAA.getKnownAlign() == 0 ? 1 : AlignAA.getKnownAlign();
+          createReplacementValues(Alignment, PrivatizableType.getValue(), ACS,
+                                  Base, NewArgOperands);
----------------
Instead, do
```
createReplacementValues(MaybeAlign(AlignAA.getKnownAlign()), PrivatizableType.getValue(), ACS, Base, NewArgOperands);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76550/new/

https://reviews.llvm.org/D76550