[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 13:34:50 PDT 2020


SouraVX updated this revision to Diff 251744.
SouraVX added a comment.

Addressed comments/suggestion by @jhenderson and @dblaikie. Thanks a lot for this!
-Removed both boolean types and introduced new helper enum `MacroSecType`. Now content parsing/dumping is based on this enum.
-Simplified interface further by moving Error handling inside function, renamed this function as `parseAndDumpMacroMacinfo`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086

Files:
  llvm/include/llvm/BinaryFormat/Dwarf.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFObject.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-macinfo.s
  llvm/test/DebugInfo/X86/debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-dwarf64-debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-opcode_operands_table-debug-macro-v5.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73086.251744.patch
Type: text/x-patch
Size: 24373 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200320/57a022c2/attachment.bin>


More information about the llvm-commits mailing list