[PATCH] D76485: [ARM] Fold VMOVrh VLDR to LDRH

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:12957
+
+    SDValue Load = DCI.DAG.getExtLoad(
+        ISD::ZEXTLOAD, SDLoc(N), VT, LN0->getChain(), LN0->getBasePtr(),
----------------
Can you call the overload of getExtLoad() that takes a MachineMemOperand ?


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:12961
+        LN0->getMemOperand()->getFlags(), LN0->getAAInfo());
+    DCI.DAG.ReplaceAllUsesOfValueWith(N0.getValue(1), Load.getValue(1));
+    return Load;
----------------
I'd prefer to do all the replacements here, instead of relying on the caller to do the remaining replacement.  This applies for all combines that are more complicated that replacing one node with another.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76485/new/

https://reviews.llvm.org/D76485