[PATCH] D76247: [MIPS] Implement MIPS3D vector instructions.

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

Some post commit remarks.



================
Comment at: llvm/lib/Target/Mips/MipsInstrFPU.td:75
                        AssemblerPredicate<(all_of (not FeatureSoftFloat))>;
+def Mips3D           : Predicate<"Subtarget->has3D()">,
+                       AssemblerPredicate<(all_of FeatureMips3D)>;
----------------
Nit: I think this should be HasMips3D.


================
Comment at: llvm/lib/Target/Mips/MipsScheduleP5600.td:23
                                          HasCnMips, HasCnMipsP,
                                          HasDSP, HasDSPR2, HasMT, HasCRC];
 }
----------------
This should include the HasMips3D predicate so that the CompleteModel check passes..


================
Comment at: llvm/lib/Target/Mips/MipsScheduleP5600.td:461
 def : InstRW<[P5600WriteFPUL], (instrs PLL_PS64, PLU_PS64, PUL_PS64, PUU_PS64)>;
+def : InstRW<[P5600WriteFPUL], (instrs ADDR_PS64, MULR_PS64)>;
+def : InstRW<[P5600WriteFPUL], (instrs CVT_PS_PW64, CVT_PW_PS64)>;
----------------
This addition looks incorrect. Looking at the MIPS32® P5600 Multiprocessing System Software User’s Manual, Revision 01.60, on page 646, it says that wired paired single is not available on the P5600.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76247/new/

https://reviews.llvm.org/D76247