[PATCH] D76460: [mlir] [VectorOps] Introduce vector.transpose on 2-D vectors

[Aart Bik via Phabricator via llvm-commits]

aartbik marked an inline comment as done.
aartbik added inline comments.


================
Comment at: mlir/lib/Dialect/Vector/VectorOps.cpp:1534
+
+static ParseResult parseTransposeOp(OpAsmParser &parser,
+                                    OperationState &result) {
----------------
nicolasvasilache wrote:
> Drop all this and use assemblyFormat instead please.
> See: https://reviews.llvm.org/D75987 for the usage of `TypesMatchWith` for dependent types.
Yes, the sole purpose of having this as C++ was to compute the type dependence. But from this feedback, I am guessing we can express this in *.td now also. Cool! Let me look into that and make the change.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76460/new/

https://reviews.llvm.org/D76460