[PATCH] D76460: [mlir] [VectorOps] Introduce vector.transpose on 2-D vectors

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 11:23:41 PDT 2020


nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/Vector/VectorOps.cpp:1534
+
+static ParseResult parseTransposeOp(OpAsmParser &parser,
+                                    OperationState &result) {
----------------
Drop all this and use assemblyFormat instead please.
See: https://reviews.llvm.org/D75987 for the usage of `TypesMatchWith` for dependent types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76460/new/

https://reviews.llvm.org/D76460





More information about the llvm-commits mailing list