[PATCH] D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 20 11:23:26 PDT 2020


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:587
+  return ".data.rel.ro";
+}
+
----------------
is this section prefixing specific to ELF, or common between all object file formats? Should the function name contain `ELF` if specific to ELF?

Is there a more specific guard we can use for `".data.rel.ro"`, returning an empty string otherwise?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72194/new/

https://reviews.llvm.org/D72194





More information about the llvm-commits mailing list